Adding different HVAC systems

chris · April 28, 2021, 4:09pm

Nice! 17 air loops! Always pushing the scale limits.

Your data trees all look correct and it sounds like the simulation is executing correctly but, yes, that looks like a bug with the names. In all likelihood the bug has something to do with these lines of code and me not understanding something about the OpenStudio SDK or standards gem:

github.com

ladybug-tools/honeybee-openstudio-gem/blob/master/lib/to_openstudio/hvac/template.rb#L80-L93


# create the HVAC system and assign the display name to the air loop name if it exists
os_hvac = openstudio_model.add_cbecs_hvac_system(standard, equipment_type, zones)
os_air_loop = nil
air_loops = openstudio_model.getAirLoopHVACs
unless air_loops.length == $air_loop_count  # check if any new loops were added
  $air_loop_count = air_loops.length
  os_air_loop = air_loops[-1]
  loop_name = os_air_loop.name
  unless loop_name.empty?
    if @hash[:display_name]
      os_air_loop.setName(@hash[:display_name] + ' - ' + loop_name.get)
    end
  end
end

Can you upload a file with the minimum that’s needed to recreate this issue and I’ll investigate?

FYI: I still have not forgotten about the other bug that you found here. It’s just that you are a pioneer in terms of the scale of some of these models and so you have found some bugs that no one else has. I promise I’ll get them all investigated and fixed as best I can over the next month.