LB_HourlyPlot - title ovelapping heatmap

AbrahamYezioro · April 5, 2022, 5:59am

Hi,
When plotting multiple data in the LB_HourlyPlot component i noticed that the title overlaps the heatmap when the number of segments of the legend is small (by user definition or by default). When the number is high enough then there is no issue.

Can this be fixed without plotting each heatmap individually?

Thanks,
-A.

chris · April 14, 2022, 1:18am

Thanks for bringing this up @AbrahamYezioro and sorry for the late response. I’ll try to come back to this tomorrow and see if I can implement a better default for this case. For now, if you need to increase the space between the plots, you can increase the 1.5 on this line of code inside the component:

github.com

ladybug-tools/ladybug-grasshopper/blob/master/ladybug_grasshopper/src/LB Hourly Plot.py#L146

    
      
                                     hour_plot.legend_parameters.text_height,
                                     hour_plot.legend_parameters.font, 1, 0)
                        for txt, pt in zip(hour_plot.month_labels, hour_plot.month_label_points2d)]
              all_labels.append(label1 + label2)
              
              # increment the base point so that the next chart doesn't overlap this one
              try:
                  next_tstep = _data[i + 1].header.analysis_period.timestep
              except IndexError:
                  next_tstep = 1
              increment = 24 * next_tstep * _y_dim_ * 1.5
              _base_pt_ = Point3D(_base_pt_.x, _base_pt_.y - increment, _base_pt_.z)
          
          
# convert nexted lists into data trees
          legend = list_to_data_tree(all_legends)
          borders = list_to_data_tree(all_borders)
          labels = list_to_data_tree(all_labels)

AbrahamYezioro · April 14, 2022, 8:08am

Hi @chris,
Thanks!
It works (of course). 1.55 works fine, instead the 1.5 in the code.
One more, cosmetic, thing, is that the font size changes between the graphs depending on the amount of divisions in the legend (i think). Would be nicer if all of them will have the same font size.
I’m picky, ah?
-A.

chris · April 15, 2022, 3:51am

I’m aware that the default text heights can be different but autocalculating the text size to always align with expectations is tough. I know we say that we want the text size to be consistent but then this can often create cases where the default text height is too small or large to be readable on some graphics. The good thing about this is that you can always specify a text_height with legend parameters to standardize the text height across your graphics to whatever you want.

Would it be alright if this is one of those cases where we expect a little extra input from the user?

AbrahamYezioro · April 15, 2022, 3:54am

Sure!! That should be the solution in the first place.
Didn’t think about this possibility in this case.
Thanks @chris,
-A.

chris · April 19, 2022, 2:10am

Hey @AbrahamYezioro ,

I just implemented a better default offset for the hourly plot, which should work well for these cases where the text height and the y-dimension of the chart are different between plots:

As I mentioned, you might still need to manually specify the text_height with the legend parameters if you want this to be consistent across the plots. But at least now the distance between the hourly plots will be responsive to this text height.

AbrahamYezioro · April 19, 2022, 3:05am

Hi @chris,
Thanks. You are beyond any expectations!! Great!!
-A.