LBT2PH Variable volume not working in recirculation cooling

anto.ac · December 3, 2021, 5:13pm

Hi @edpmay, the variable volume setting for the recirculation cooling does not seem to work. I have tried with boolean toggles or “x” - “” panels but it seems to be stuck on “x” regardless. Do you know why?
Thanks!

TrevorFedyna · December 3, 2021, 5:57pm

@edpmay sent a PR on git, its not been tested in terms of input into a PHPP but it fixes the issue with the compo function

anto.ac · December 3, 2021, 6:03pm

Hi @TrevorFedyna , sorry I am not that familiar with the slang: what is a PR? where do I find it and how do I use it?
Thanks!

TrevorFedyna · December 3, 2021, 6:14pm

Hi, I edited the source code and sent a request to Ed to review it prior to merging it into the codebase, I did not validate anything past the component output; as I don’t have a rigged up LBT-2-PH model applicable to testing functionality completely: so I’d wait on Ed getting back on this

edpmay · December 5, 2021, 5:24pm

Thanks for doing that @TrevorFedyna ! That worked great. All seems to be working for me now:

With Variable Volume on:

and with Variable Volume off:

I just approved and merged that PR. @anto.ac : note that for the change to work for you, you’ll just want to grab the updated scripts from the GH-Repository with Trevor’s edits.

thanks!!
@edpmay