Validation Exception for Daylight Model

surabhisaran · April 23, 2024, 10:16am

Hi @chris
Regarding the HB Validate Model component , I am getting a constant traceback error when I run the component. The Daylight model simulates but I suspect it is not accurate as I get different results from my colleagues , even though we use the same script with the same parameters. This has happened across multiple different models
Do you know what could be the error?
Thanks in advance

chris · May 29, 2024, 6:39pm

Hi @surabhisaran ,

Sorry that no one responded to this a year ago but it was out of place in the original discussion so I moved it to a new one. The code has changed quite a lot since the version that you have there but, thanks to the magic of GitHub versioning, I know that this was the exact line that was failing for you a year ago:

github.com

ladybug-tools/honeybee-core/blob/29bf4d498687ed5361ded31dd49d7023c7befec1/honeybee/room.py#L1919


      
                  except KeyError:  # this is the first room with this floor height
                      flrhgt_dict[flrhgt] = []
                      flrhgt_dict[flrhgt].append(room)
          
              # sort the rooms by floor heights
              room_mtx = sorted(flrhgt_dict.items(), key=lambda d: float(d[0]))
              flr_hgts = [r_tup[0] for r_tup in room_mtx]
              rooms = [r_tup[1] for r_tup in room_mtx]
          
              # group floor heights if they differ by less than the min_difference
              floor_heights = [flr_hgts[0]]
              grouped_rooms = [rooms[0]]
              for flrh, rm in zip(flr_hgts[1:], rooms[1:]):
                  if flrh - floor_heights[-1] < min_difference:
                      grouped_rooms[-1].extend(rm)
                  else:
                      grouped_rooms.append(rm)
                      floor_heights.append(flrh)
              return grouped_rooms, floor_heights
          
          @staticmethod

So it seems that this was a bug related to Models without any Rooms and it seems like it was fixed 7 months ago:

So just update to LBT 1.8.0 and you should be fine.

surabhisaran · June 7, 2024, 9:07am

Thankyou Chris! We updated to LBT1.8 & this error has disappeared. Much Appreciated!